Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neon_local: background_process: launch all processes in repo dir (or datadir) #8058

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

problame
Copy link
Contributor

@problame problame commented Jun 14, 2024

Before this PR, storage controller and broker would run in the
PWD of neon_local, i.e., most likely the checkout of neon.git.

With this PR, the shared infrastructure for background processes
sets the PWD.

Benefits:

  • easy listing of processes in a repo dir using lsof, see added
    comment in the code
  • coredumps go in the right directory (next to the process)
  • generally matching common expectations, I think

Changes:

  • set the working directory in background_process module
  • drive-by: fix reliance of storage_controller on NEON_REPO_DIR being set by neon_local for the local compute hook to work correctly

Before this PR, storage controller and broker would run in the
PWD of neon_local, i.e., most likely the checkout of neon.git.

With this PR, the shared infrastructure for background processes
sets the PWD.

Benefits:
* easy listing of processes in a repo dir using `lsof`, see added
  comment in the code
* coredumps go in the right directory (next to the process)
* generally matching common expectations, I think
@problame problame requested a review from bayandin June 14, 2024 09:37
…LocalEnv::load_config()

fix that by adding a CLI flag to storage controller that adds a
dedicated "neon_local" mode
Copy link

3216 tests run: 3075 passed, 0 failed, 141 skipped (full report)


Flaky tests (2)

Postgres 14

  • test_subscriber_restart: release
  • test_synthetic_size_while_deleting: release

Code coverage* (full report)

  • functions: 31.5% (6636 of 21063 functions)
  • lines: 48.6% (51635 of 106323 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e14801e at 2024-06-14T13:51:19.322Z :recycle:

@problame problame marked this pull request as ready for review June 14, 2024 14:00
@problame problame requested a review from a team as a code owner June 14, 2024 14:00
@problame problame requested a review from VladLazar June 14, 2024 14:00
@problame problame changed the title neon_local: launch all processes in repo dir or below neon_local: background_process: launch all processes in repo dir (or datadir) Jun 14, 2024
storage_controller/src/main.rs Show resolved Hide resolved
@problame problame merged commit 438fd2a into main Jun 19, 2024
65 checks passed
@problame problame deleted the problame/neon_local-defined-pwd branch June 19, 2024 11:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants