Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add helper function for importing a Postgres cluster #8025

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

hlinnaka
Copy link
Contributor

@hlinnaka hlinnaka commented Jun 12, 2024

Also, modify the "neon_local timeline import" command so that it
doesn't create the endpoint anymore. I don't see any reason to bundle
that in the same command, the "timeline create" and "timeline branch"
commands don't do that either.

I plan to add more tests similar to 'test_import_at_2bil', this will help to reduce the copy-pasting.

@hlinnaka hlinnaka requested review from a team and lubennikovaav and removed request for a team June 12, 2024 08:54
Copy link

github-actions bot commented Jun 12, 2024

2934 tests run: 2818 passed, 0 failed, 116 skipped (full report)


Code coverage* (full report)

  • functions: 32.6% (6891 of 21116 functions)
  • lines: 50.0% (53918 of 107843 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d9913e4 at 2024-06-26T22:03:42.846Z :recycle:

@hlinnaka hlinnaka force-pushed the refactor-import-vanilla-pg-test branch from acdd3d5 to dd3b461 Compare June 12, 2024 12:43
hlinnaka added a commit that referenced this pull request Jun 12, 2024
Also, modify the "neon_local timeline import" command so that it
doesn't create the endpoint anymore. I don't see any reason to bundle
that in the same command, the "timeline create" and "timeline branch"
commands don't do that either.

I plan to add more tests similar to 'test_import_at_2bil', this will
help to reduce the copy-pasting.
@hlinnaka hlinnaka force-pushed the refactor-import-vanilla-pg-test branch from dd3b461 to f922f57 Compare June 12, 2024 12:44
hlinnaka added a commit that referenced this pull request Jun 12, 2024
Also, modify the "neon_local timeline import" command so that it
doesn't create the endpoint anymore. I don't see any reason to bundle
that in the same command, the "timeline create" and "timeline branch"
commands don't do that either.

I plan to add more tests similar to 'test_import_at_2bil', this will
help to reduce the copy-pasting.
@hlinnaka hlinnaka force-pushed the refactor-import-vanilla-pg-test branch from f922f57 to af61542 Compare June 12, 2024 13:35
hlinnaka added a commit that referenced this pull request Jun 12, 2024
Also, modify the "neon_local timeline import" command so that it
doesn't create the endpoint anymore. I don't see any reason to bundle
that in the same command, the "timeline create" and "timeline branch"
commands don't do that either.

I plan to add more tests similar to 'test_import_at_2bil', this will
help to reduce the copy-pasting.
@hlinnaka hlinnaka force-pushed the refactor-import-vanilla-pg-test branch from af61542 to bad5a71 Compare June 12, 2024 13:37
hlinnaka added a commit that referenced this pull request Jun 13, 2024
Also, modify the "neon_local timeline import" command so that it
doesn't create the endpoint anymore. I don't see any reason to bundle
that in the same command, the "timeline create" and "timeline branch"
commands don't do that either.

I plan to add more tests similar to 'test_import_at_2bil', this will
help to reduce the copy-pasting.
hlinnaka added a commit that referenced this pull request Jun 13, 2024
Also, modify the "neon_local timeline import" command so that it
doesn't create the endpoint anymore. I don't see any reason to bundle
that in the same command, the "timeline create" and "timeline branch"
commands don't do that either.

I plan to add more tests similar to 'test_import_at_2bil', this will
help to reduce the copy-pasting.
@hlinnaka hlinnaka force-pushed the refactor-import-vanilla-pg-test branch from bad5a71 to 988cd47 Compare June 13, 2024 22:31
hlinnaka added a commit that referenced this pull request Jun 18, 2024
Also, modify the "neon_local timeline import" command so that it
doesn't create the endpoint anymore. I don't see any reason to bundle
that in the same command, the "timeline create" and "timeline branch"
commands don't do that either.

I plan to add more tests similar to 'test_import_at_2bil', this will
help to reduce the copy-pasting.
@hlinnaka hlinnaka force-pushed the refactor-import-vanilla-pg-test branch from 988cd47 to 377db4a Compare June 18, 2024 11:27
@hlinnaka hlinnaka requested review from a team and skyzh and removed request for a team June 18, 2024 11:27
hlinnaka added a commit that referenced this pull request Jun 25, 2024
Also, modify the "neon_local timeline import" command so that it
doesn't create the endpoint anymore. I don't see any reason to bundle
that in the same command, the "timeline create" and "timeline branch"
commands don't do that either.

I plan to add more tests similar to 'test_import_at_2bil', this will
help to reduce the copy-pasting.
@hlinnaka hlinnaka force-pushed the refactor-import-vanilla-pg-test branch from 377db4a to 576c9e5 Compare June 25, 2024 18:45
hlinnaka added a commit that referenced this pull request Jun 25, 2024
Also, modify the "neon_local timeline import" command so that it
doesn't create the endpoint anymore. I don't see any reason to bundle
that in the same command, the "timeline create" and "timeline branch"
commands don't do that either.

I plan to add more tests similar to 'test_import_at_2bil', this will
help to reduce the copy-pasting.
@hlinnaka hlinnaka force-pushed the refactor-import-vanilla-pg-test branch from 576c9e5 to 6816144 Compare June 25, 2024 18:45
@hlinnaka hlinnaka requested a review from knizhnik June 25, 2024 19:19
Also, modify the "neon_local timeline import" command so that it
doesn't create the endpoint anymore. I don't see any reason to bundle
that in the same command, the "timeline create" and "timeline branch"
commands don't do that either.

I plan to add more tests similar to 'test_import_at_2bil', this will
help to reduce the copy-pasting.
@hlinnaka hlinnaka force-pushed the refactor-import-vanilla-pg-test branch from 6816144 to d9913e4 Compare June 26, 2024 21:11
@hlinnaka hlinnaka enabled auto-merge (squash) June 26, 2024 21:19
@hlinnaka hlinnaka merged commit d275371 into main Jun 26, 2024
57 of 58 checks passed
@hlinnaka hlinnaka deleted the refactor-import-vanilla-pg-test branch June 26, 2024 21:54
conradludgate pushed a commit that referenced this pull request Jun 27, 2024
Also, modify the "neon_local timeline import" command so that it
doesn't create the endpoint any more. I don't see any reason to bundle
that in the same command, the "timeline create" and "timeline branch"
commands don't do that either.

I plan to add more tests similar to 'test_import_at_2bil', this will
help to reduce the copy-pasting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants