Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the problem the docker compose caused by the extensions tests #8024

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

a-masterov
Copy link
Contributor

@a-masterov a-masterov commented Jun 12, 2024

Problem

The merging of #7818 caused the problem with the docker-compose file. Running docker compose is now impossible due to the unavailability of the neon-test-extensions:latest image

Summary of changes

Fix the problem:
Add the latest tag to the neon-test-extensions image and use the profiles feature of the docker-compose file to avoid loading the neon-test-extensions container if it is not needed.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@a-masterov a-masterov requested a review from bayandin June 12, 2024 07:33
@a-masterov a-masterov changed the title Add the tag latest to the image neon-test-extensions Resolve the problem the docker compose caused by the extensions tests Jun 12, 2024
docker-compose/docker_compose_test.sh Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jun 12, 2024

3210 tests run: 3068 passed, 0 failed, 142 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_pageserver_restarts_under_worload: release

Code coverage* (full report)

  • functions: 31.6% (6632 of 20990 functions)
  • lines: 48.6% (51494 of 106045 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4a3ca27 at 2024-06-12T10:04:34.437Z :recycle:

@a-masterov a-masterov merged commit f749437 into main Jun 12, 2024
69 of 70 checks passed
@a-masterov a-masterov deleted the amasterov/fix-docker-compose branch June 12, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants