Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix duplicated harness name #8010

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

koivunej
Copy link
Member

We need unique tenant harness names in case you want to inspect the results of the last failing run. We are not using any proc macros to get the test name as there is no stable way of doing that, and there will not be one in the future, so we need to fix these duplicates.

Also, clean up the duplicated tests to not mix ? and unwrap/assert.

@koivunej koivunej requested a review from skyzh June 11, 2024 12:08
@koivunej koivunej requested a review from a team as a code owner June 11, 2024 12:08
@koivunej koivunej enabled auto-merge (squash) June 11, 2024 12:09
Copy link

3198 tests run: 3056 passed, 0 failed, 142 skipped (full report)


Flaky tests (2)

Postgres 15

  • test_timeline_size_quota_on_startup: release

Postgres 14

  • test_storage_controller_smoke: release

Code coverage* (full report)

  • functions: 31.5% (6606 of 20962 functions)
  • lines: 48.5% (51110 of 105431 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ed71845 at 2024-06-11T12:59:03.544Z :recycle:

@koivunej koivunej merged commit d3b892e into main Jun 11, 2024
64 checks passed
@koivunej koivunej deleted the joonas/fix_test_duplicated_name branch June 11, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants