Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove random sleep in partial backup #7982

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

petuhovskiy
Copy link
Member

@petuhovskiy petuhovskiy commented Jun 6, 2024

We had a random sleep in the beginning of partial backup task, which was needed for the first partial backup deploy. It helped with gradual upload of segments without causing network overload. Now partial backup is deployed everywhere, so we don't need this random sleep anymore.

We also had an issue related to this, in which manager task was not shut down for a long time. The cause of the issue is this random sleep that didn't take timeline cancellation into account, meanwhile manager task waited for partial backup to complete.

Fixes #7967

@petuhovskiy petuhovskiy requested a review from a team as a code owner June 6, 2024 11:36
@petuhovskiy petuhovskiy requested a review from arssher June 6, 2024 11:36
Copy link

github-actions bot commented Jun 6, 2024

3210 tests run: 3071 passed, 0 failed, 139 skipped (full report)


Flaky tests (6)

Postgres 16

  • test_storage_controller_smoke: debug

Postgres 15

  • test_pageserver_restarts_under_worload: release
  • test_storage_controller_smoke: debug
  • test_vm_bit_clear_on_heap_lock: debug

Postgres 14

  • test_pageserver_restarts_under_worload: release
  • test_subscriber_restart: release

Code coverage* (full report)

  • functions: 31.5% (6596 of 20927 functions)
  • lines: 48.5% (51050 of 105267 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
35b5bba at 2024-06-06T18:02:56.535Z :recycle:

@petuhovskiy petuhovskiy enabled auto-merge (squash) June 6, 2024 14:13
@petuhovskiy petuhovskiy merged commit e4e444f into main Jun 6, 2024
64 checks passed
@petuhovskiy petuhovskiy deleted the fix-stuck-sk-manager branch June 6, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

too many timelines in broker_active_set
2 participants