perf(pageserver): postpone vectored get fringe keyspace construction #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chi Z <chi@neon.tech>
3144 tests run: 3011 passed, 0 failed, 133 skipped (full report)Flaky tests (3)Postgres 16Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
d605bd1 at 2024-05-29T16:32:17.922Z :recycle: |
jcsp
approved these changes
May 30, 2024
There was a problem hiding this comment.
LGTM
(CC @VladLazar so that this is in your inbox when you're back in the office.)
|
On staging the basebackup time drops to a reasonable number (30s->2s for now). With the delete tombstone pull request it should be even faster. |
a-masterov
pushed a commit
that referenced
this pull request
Jun 3, 2024
…7904) Perf shows a significant amount of time is spent on `Keyspace::merge`. This pull request postpones merging keyspace until retrieving the layer, which contributes to a 30x improvement in aux keyspace basebackup time. ``` --- old 10000 files found in 0.580569459s --- new 10000 files found in 0.02995075s ``` Signed-off-by: Alex Chi Z <chi@neon.tech>
VladLazar
reviewed
Jun 10, 2024
| @@ -318,7 +318,7 @@ pub(crate) struct LayerFringe { | |||
| #[derive(Debug)] | |||
| struct LayerKeyspace { | |||
| layer: ReadableLayer, | |||
| target_keyspace: KeySpace, | |||
| target_keyspace: Vec<KeySpace>, | |||
There was a problem hiding this comment.
nit: making this member a KeySpaceRandomAccum would have been more expressive in my opinion, but this is fine.
|
Looks good to me as well. Nice find, Chi! |
5 tasks
skyzh
added a commit
that referenced
this pull request
Jun 14, 2024
follow up on #7904 avoid a layer of indirection introduced by `Vec<Range<Key>>` Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Perf shows a significant amount of time is spent on
Keyspace::merge. This pull request postpones merging keyspace until retrieving the layer, which contributes to a 30x improvement in aux keyspace basebackup time.Summary of changes
Checklist before requesting a review
Checklist before merging