Long-running replication tests #7896

save-buffer · 2024-05-28T15:44:16Z

Problem

We need long-running stress tests for replication.

Summary of changes

Add them

Related to neondatabase/cloud#13390, neondatabase/cloud#14490, neondatabase/cloud#14724

github-actions · 2024-05-28T17:13:01Z

3092 tests run: 2977 passed, 0 failed, 115 skipped (full report)

Flaky tests (3)

Postgres 16

test_lsn_lease_size[False]: debug

Postgres 14

test_subscriber_restart: release
test_lsn_lease_size[False]: debug

Code coverage* (full report)

functions: 32.6% (6935 of 21279 functions)
lines: 50.0% (54525 of 109034 lines)

* collected from Rust tests only

_{The comment gets automatically updated with the latest test results
5e10906 at 2024-07-07T09:34:33.528Z :recycle:}

test_runner/fixtures/neon_fixtures.py

test_runner/performance/neon_api.py

test_runner/performance/test_physical_replication.py

andreasscherbaum · 2024-06-04T15:59:20Z

Let's merge this one, then change it to use the same project every time.

Use long-running queries, "start a transaction, query some tables, then use pg_sleep()".
Change transaction isolation level in tests.

test_runner/fixtures/neon_fixtures.py

test_runner/performance/neon_api.py

test_runner/performance/test_physical_replication.py

tristan957

From my perspective, this looks good.

test_runner/performance/neon_api.py

test_runner/performance/test_physical_replication.py

kelvich · 2024-07-01T22:08:34Z

@save-buffer is OOO for few days, so feel free to merge this

test_runner/fixtures/neon_fixtures.py

test_runner/performance/test_logical_replication.py

test_runner/performance/test_physical_replication.py

tristan957 · 2024-07-02T20:50:50Z

I'll take this over for Sasha while he is out.

tristan957 · 2024-07-03T20:29:02Z

I cleaned up the commit history, and I think got to all of the review comments. I also rebased on main. How can we test this to make sure I didn't screw it up touching everything up?

bayandin · 2024-07-03T22:27:52Z

Fixed bad merge, a couple of missed issues and retriggered it here: https://github.com/neondatabase/neon/actions/runs/9785504530/job/27018662789

UPD: the test run looks good!

a-masterov

No problems found

tristan957 · 2024-07-05T18:07:46Z

Good work on this everybody!

No need to import it if we aren't type checking anything.

This is a Python binding to the Neon HTTP API. It isn't complete, but can be extended as necessary. Co-authored-by: Sasha Krassovsky <sasha@neon.tech>

Useful for debugging situations like connecting to databases. Co-authored-by: Sasha Krassovsky <sasha@neon.tech>

Allows a process to run without blocking program execution, which can be useful for certain test scenarios. Co-authored-by: Sasha Krassovsky <sasha@neon.tech>

tristan957 · 2024-07-05T18:10:13Z

Ugh. @bayandin I just overwrote your commits rebasing on main to get the conclusion job. Can you add them back when you get a chance. I am such an idiot.

bayandin · 2024-07-05T18:13:10Z

Can you add them back when you get a chance

No problem! Will do tomorrow (I'm afk for the rest of the day)

tristan957 · 2024-07-05T18:42:25Z

Please enjoy your weekend :)

These tests will help verify that replication, both physical and logical, works as expected in Neon. Co-authored-by: Sasha Krassovsky <sasha@neon.tech>

save-buffer marked this pull request as draft May 28, 2024 15:44

tristan957 reviewed Jun 3, 2024

View reviewed changes

save-buffer force-pushed the tristan957/replication branch from 91dbebf to 2be3279 Compare June 4, 2024 19:05

tristan957 reviewed Jun 4, 2024

View reviewed changes

test_runner/fixtures/neon_fixtures.py Outdated Show resolved Hide resolved

test_runner/performance/neon_api.py Outdated Show resolved Hide resolved

save-buffer marked this pull request as ready for review June 4, 2024 19:54

tristan957 reviewed Jun 4, 2024

View reviewed changes

test_runner/performance/test_physical_replication.py Outdated Show resolved Hide resolved

test_runner/performance/test_physical_replication.py Outdated Show resolved Hide resolved

tristan957 approved these changes Jun 5, 2024

View reviewed changes

bayandin self-requested a review June 5, 2024 20:43

bayandin requested changes Jun 6, 2024

View reviewed changes

bayandin reviewed Jun 11, 2024

View reviewed changes

test_runner/performance/test_physical_replication.py Show resolved Hide resolved

save-buffer force-pushed the tristan957/replication branch from 9861d81 to 9617059 Compare June 12, 2024 20:34

tristan957 force-pushed the tristan957/replication branch from 5327d4e to 713238c Compare June 13, 2024 20:38

a-masterov requested changes Jun 14, 2024

View reviewed changes

test_runner/performance/test_physical_replication.py Outdated Show resolved Hide resolved

test_runner/performance/test_physical_replication.py Outdated Show resolved Hide resolved

a-masterov requested changes Jun 14, 2024

View reviewed changes

test_runner/performance/test_physical_replication.py Outdated Show resolved Hide resolved

save-buffer requested review from a-masterov and bayandin June 14, 2024 21:58

a-masterov reviewed Jun 17, 2024

View reviewed changes

save-buffer requested a review from a-masterov June 17, 2024 18:40

save-buffer force-pushed the tristan957/replication branch from 5dc66b6 to 3c156e6 Compare June 17, 2024 18:45

save-buffer requested review from a team as code owners June 17, 2024 18:45

save-buffer requested review from khanova, knizhnik and arssher June 17, 2024 18:45

save-buffer force-pushed the tristan957/replication branch from 3c156e6 to 8954b86 Compare June 17, 2024 18:45

save-buffer removed the request for review from a team June 17, 2024 18:53

bayandin requested a review from a-masterov July 1, 2024 14:11

a-masterov reviewed Jul 2, 2024

View reviewed changes

tristan957 force-pushed the tristan957/replication branch from 5a929a3 to c8aa9ec Compare July 3, 2024 20:27

This comment was marked as outdated.

Sign in to view

bayandin force-pushed the tristan957/replication branch 3 times, most recently from 6dc04d0 to 9ced616 Compare July 3, 2024 22:18

bayandin requested a review from a-masterov July 4, 2024 08:56

a-masterov approved these changes Jul 5, 2024

View reviewed changes

tristan957 enabled auto-merge (rebase) July 5, 2024 18:07

tristan957 and others added 4 commits July 5, 2024 13:08

Hide import behind TYPE_CHECKING

9ceb139

No need to import it if we aren't type checking anything.

Add Neon HTTP API test fixture

2e6b358

This is a Python binding to the Neon HTTP API. It isn't complete, but can be extended as necessary. Co-authored-by: Sasha Krassovsky <sasha@neon.tech>

Log PG environment variables when a PgBin runs

ff1ad97

Useful for debugging situations like connecting to databases. Co-authored-by: Sasha Krassovsky <sasha@neon.tech>

Add PgBin.run_nonblocking()

cbe25b6

Allows a process to run without blocking program execution, which can be useful for certain test scenarios. Co-authored-by: Sasha Krassovsky <sasha@neon.tech>

tristan957 force-pushed the tristan957/replication branch from 9ced616 to 121385c Compare July 5, 2024 18:08

tristan957 disabled auto-merge July 5, 2024 18:09

bayandin force-pushed the tristan957/replication branch from 121385c to 95704e9 Compare July 6, 2024 23:35

Add long running replication tests

5e10906

These tests will help verify that replication, both physical and logical, works as expected in Neon. Co-authored-by: Sasha Krassovsky <sasha@neon.tech>

bayandin force-pushed the tristan957/replication branch from 95704e9 to 5e10906 Compare July 6, 2024 23:37

tristan957 enabled auto-merge (rebase) July 8, 2024 14:30

tristan957 merged commit 1c57f6b into main Jul 8, 2024
69 checks passed

tristan957 deleted the tristan957/replication branch July 8, 2024 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Long-running replication tests #7896

Long-running replication tests #7896

save-buffer commented May 28, 2024 •

edited by ololobus

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

Postgres 16

Postgres 14

andreasscherbaum commented Jun 4, 2024

tristan957 left a comment

kelvich commented Jul 1, 2024

tristan957 commented Jul 2, 2024

tristan957 commented Jul 3, 2024

This comment was marked as outdated.

bayandin commented Jul 3, 2024 •

edited

Loading

a-masterov left a comment

tristan957 commented Jul 5, 2024

tristan957 commented Jul 5, 2024

bayandin commented Jul 5, 2024

tristan957 commented Jul 5, 2024

Long-running replication tests #7896

Long-running replication tests #7896

Conversation

save-buffer commented May 28, 2024 • edited by ololobus Loading

Problem

Summary of changes

github-actions bot commented May 28, 2024 • edited Loading

3092 tests run: 2977 passed, 0 failed, 115 skipped (full report)

Postgres 16

Postgres 14

Code coverage* (full report)

andreasscherbaum commented Jun 4, 2024

tristan957 left a comment

Choose a reason for hiding this comment

kelvich commented Jul 1, 2024

tristan957 commented Jul 2, 2024

tristan957 commented Jul 3, 2024

This comment was marked as outdated.

bayandin commented Jul 3, 2024 • edited Loading

a-masterov left a comment

Choose a reason for hiding this comment

tristan957 commented Jul 5, 2024

tristan957 commented Jul 5, 2024

bayandin commented Jul 5, 2024

tristan957 commented Jul 5, 2024

save-buffer commented May 28, 2024 •

edited by ololobus

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

bayandin commented Jul 3, 2024 •

edited

Loading