Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apostrophe #7868

Merged
merged 1 commit into from
May 23, 2024
Merged

Remove apostrophe #7868

merged 1 commit into from
May 23, 2024

Conversation

save-buffer
Copy link
Contributor

Problem

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@save-buffer save-buffer requested a review from sharnoff May 23, 2024 19:55
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to link prior discussion, otherwise lgtm

@save-buffer save-buffer enabled auto-merge (squash) May 23, 2024 19:58
@save-buffer
Copy link
Contributor Author

@save-buffer save-buffer merged commit ea2e830 into main May 23, 2024
56 of 57 checks passed
@save-buffer save-buffer deleted the sasha_rm_apostraphe branch May 23, 2024 20:36
Copy link

3108 tests run: 2981 passed, 0 failed, 127 skipped (full report)


Code coverage* (full report)

  • functions: 31.4% (6450 of 20545 functions)
  • lines: 48.3% (49878 of 103268 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
814cab6 at 2024-05-23T20:43:55.721Z :recycle:

save-buffer pushed a commit that referenced this pull request May 23, 2024
## Problem

## Summary of changes

## Checklist before requesting a review

- [ ] I have performed a self-review of my code.
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Do we need to implement analytics? if so did you add the relevant
metrics to the dashboard?
- [ ] If this PR requires public announcement, mark it with
/release-notes label and add several sentences in this section.

## Checklist before merging

- [ ] Do not forget to reformat commit message to not include the above
checklist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants