Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Timeline::create_image_layer_for_rel_blocks in tiered compaction #7850

Merged
merged 2 commits into from
May 23, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented May 22, 2024

Reduces duplication between tiered and legacy compaction by using the Timeline::create_image_layer_for_rel_blocks function. This way, we also use vectored get in tiered compaction, so the change has two benefits in one.

fixes #7659

@arpad-m arpad-m requested a review from a team as a code owner May 22, 2024 22:56
@arpad-m arpad-m requested a review from VladLazar May 22, 2024 22:56
Copy link

github-actions bot commented May 22, 2024

3108 tests run: 2981 passed, 0 failed, 127 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_synthetic_size_while_deleting: debug

Code coverage* (full report)

  • functions: 31.4% (6451 of 20545 functions)
  • lines: 48.3% (49881 of 103268 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ddb6f02 at 2024-05-23T15:19:04.314Z :recycle:

@arpad-m arpad-m requested a review from skyzh May 23, 2024 12:29
pageserver/src/tenant/timeline/compaction.rs Outdated Show resolved Hide resolved
Co-authored-by: Alex Chi Z. <iskyzh@gmail.com>
@arpad-m arpad-m enabled auto-merge (squash) May 23, 2024 14:22
@arpad-m arpad-m merged commit 75a52ac into main May 23, 2024
56 of 57 checks passed
@arpad-m arpad-m deleted the arpad/compaction_vectored_get branch May 23, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiered compaction: switch to vectored get
2 participants