-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pageserver: remove Option<> around remote storage, clean up metadata file refs #7752
Conversation
3060 tests run: 2933 passed, 0 failed, 127 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
d79e9e5 at 2024-05-15T12:14:06.640Z :recycle: |
88937c2
to
814dedb
Compare
814dedb
to
6ca7cca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - did you already broadcast this on discord?
Also should your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with the thim
typo fix pointed out by Vlad.
…file refs (#7752) ## Problem This is historical baggage from when the pageserver could be run with local disk only: we had a bunch of places where we had to treat remote storage as optional. Closes: #6890 ## Changes - Remove Option<> around remote storage (in #7722 we made remote storage clearly mandatory) - Remove code for deleting old metadata files: they're all gone now. - Remove other references to metadata files when loading directories, as none exist. I checked last 14 days of logs for "found legacy metadata", there are no instances.
Problem
This is historical baggage from when the pageserver could be run with local disk only: we had a bunch of places where we had to treat remote storage as optional.
Closes: #6890
Changes
I checked last 14 days of logs for "found legacy metadata", there are no instances.
Checklist before requesting a review
Checklist before merging