Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi: document timeline ancestor detach #7650

Merged
merged 12 commits into from
May 22, 2024
Merged

openapi: document timeline ancestor detach #7650

merged 12 commits into from
May 22, 2024

Conversation

koivunej
Copy link
Member

@koivunej koivunej commented May 8, 2024

The openapi description with the error descriptions:

  • 200 is used for "detached or has been detached previously"
  • 400 is used for "cannot be detached right now" -- it's an odd thing, but good enough
  • 404 is used for tenant or timeline not found
  • 409 is used for "can never be detached" (root timeline)
  • 500 is used for transient errors (basically ill-defined shutdown errors)
  • 503 is used for busy (other tenant ancestor detach underway, pageserver shutdown)

Cc: #6994

Copy link

github-actions bot commented May 21, 2024

3126 tests run: 2999 passed, 0 failed, 127 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_no_config[application/json]: release

Postgres 15

  • test_secondary_background_downloads: release

Postgres 14

  • test_vm_bit_clear_on_heap_lock: debug

Code coverage* (full report)

  • functions: 31.3% (6414 of 20478 functions)
  • lines: 48.0% (49311 of 102655 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d8e56e7 at 2024-05-22T14:03:51.423Z :recycle:

@koivunej koivunej requested a review from jcsp May 22, 2024 08:19
pageserver/src/http/routes.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jcsp jcsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, no hard blockers

@koivunej koivunej enabled auto-merge (squash) May 22, 2024 12:24
@koivunej koivunej disabled auto-merge May 22, 2024 12:24
@koivunej koivunej changed the title openapi: document ancestor detach openapi: document timeline ancestor detach May 22, 2024
@koivunej koivunej enabled auto-merge (squash) May 22, 2024 13:05
@koivunej
Copy link
Member Author

  • test_no_config[application/json]: release

Fix in #7839

@koivunej koivunej merged commit ce44dfe into main May 22, 2024
55 checks passed
@koivunej koivunej deleted the joonas/openapi_tad branch May 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants