refactor(ephemeral_file): bring back pre-warming of PS page cache on write #7511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or-ephemeral-file-reuse-buffered-io' into problame/larger-buffers-io/refactor-ephemeral-file-reuse-buffered-io--with-write-path-prewarming
…e-buffered-io' into problame/larger-buffers-io/refactor-ephemeral-file-reuse-buffered-io--with-write-path-prewarming
2766 tests run: 2646 passed, 0 failed, 120 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
d928ad6 at 2024-04-25T14:33:25.921Z :recycle: |
VladLazar
reviewed
Apr 25, 2024
pageserver/src/tenant/ephemeral_file/zero_padded_read_write/flush_detector.rs
Outdated
Show resolved
Hide resolved
problame
merged commit 287d1bf
into
problame/larger-buffers-io/refactor-ephemeral-file-reuse-buffered-io
42 of 43 checks passed
problame
deleted the
problame/larger-buffers-io/refactor-ephemeral-file-reuse-buffered-io--with-write-path-prewarming
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent PR #7484 is showing a performance regression in
test_bulk_ingest.py.I tracked it down to the removal of PS page cache pre-warming: the InMemoryLayer=>L0 writing path seems to benefit from PS page cache for its reads.
So, this PR adds back the pre-warming.
We don't funnel through RequestContext down to the VirtualFile level yet, so, I use a
staticrequest context.See https://neondb.slack.com/archives/C033RQ5SPDH/p1713890189520339?thread_ts=1713433920.576379&cid=C033RQ5SPDH for more details on the perf investigation.