Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Fix cancellations #7510

Merged
merged 1 commit into from
Apr 25, 2024
Merged

proxy: Fix cancellations #7510

merged 1 commit into from
Apr 25, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Apr 25, 2024

Problem

Cancellations were published to the channel, that was never read.

Summary of changes

Fallback to global redis publishing.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova requested a review from a team as a code owner April 25, 2024 11:04
@khanova khanova changed the title Fix cancellations proxy: Fix cancellations Apr 25, 2024
@khanova khanova enabled auto-merge (squash) April 25, 2024 11:10
@khanova khanova merged commit b1d47f3 into main Apr 25, 2024
48 of 49 checks passed
@khanova khanova deleted the proxy-fix-cancellations branch April 25, 2024 11:38
khanova added a commit that referenced this pull request Apr 25, 2024
## Problem

Cancellations were published to the channel, that was never read.

## Summary of changes

Fallback to global redis publishing.
Copy link

2766 tests run: 2645 passed, 0 failed, 121 skipped (full report)


Code coverage* (full report)

  • functions: 28.1% (6478 of 23037 functions)
  • lines: 46.9% (46015 of 98022 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
18e6798 at 2024-04-25T11:46:36.520Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants