-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to specify the upload_storage_class in S3 bucket configuration #7461
Conversation
2766 tests run: 2645 passed, 0 failed, 121 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
4608a4a at 2024-04-24T15:57:36.177Z :recycle: |
it's not needed
d98e499
to
f78633d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is any situation where we wouldn't want to do this, so approving. It can later be made a bucket setting, but cannot see a reason why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the PR description doesn't explain that this is mostly to have cleaner billing reports: https://github.com/neondatabase/cloud/issues/11348#issuecomment-2069597349
Hmm the error is legit (link):
|
Configurability is needed after all. This reverts commit f78633d.
On slack we agreed to make it configurable instead (and leave it off by default) to help people who use S3 clones like minio, e.g. selfhosters, but also various local development workflows in Neon (like the failing CI job). We'll then set the parameters in production pageserver configuration. |
Currently we move data to the intended storage class via lifecycle rules, but those are a daily batch job so data first spends up to a day in standard storage.
Therefore, make it possible to specify the storage class used for uploads to S3 so that the data doesn't have to be migrated automatically.
The advantage of this is that it gives cleaner billing reports.
Part of https://github.com/neondatabase/cloud/issues/11348