-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pageserver: remove import/export script previously used for breaking format changes #7458
Conversation
-1, it's very handy while debugging. @kelvich and I used it just last week when debugging a production issue. And we will eventually need the functionality for a user-exposed export feature. It was discussed as part of pg_upgrade, too. I agree it's not how we'd want to do major storage format changes in the future. Some comment cleanup would be in order, to explain why the command still exists. |
scratch that part, that was about the |
2760 tests run: 2642 passed, 0 failed, 118 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
7656930 at 2024-04-22T17:30:15.468Z :recycle: |
Ok, let's leave it in that case. Did you use the |
I don't remember; @kelvich do you? The import part of the script certainly seems less interesting. And the |
I usually use it manually: |
Would be nice to have this procedure written down somewhere. The immediate next question is, what do you do with the fullbackup after you got it. I guess you'd use |
Oke, so based on the feedback above, I will:
|
162141d
to
7656930
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked if we still have test coverage for the fullbackup method; yes we do, tests test_import_from_pageserver_*.
Problem
The
fullbackup
command enabled us to do major storage format changes in the past.If we have to do such breaking changes in the future this approach wouldn't be suitable because:
Summary of changes
Remove the
fullbackup
command handling and it's only user, the import/export script.Note that I've kept the
import basebackup
andimport wal
commands since:neon_local
import commandCloses https://github.com/neondatabase/cloud/issues/11648
Checklist before requesting a review
Checklist before merging