pageserver/config: disable image layer creation check threshold #7414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Christian diagnosed the compaction change in #7230 as the root cause for slow
find_lsn_for_timestamp
in prod.The essence of the problem is that
Timeline::last_image_layer_creation_check_at
is updated after the first partition, causing all remaining ones to skip image layer creation.Details: https://neondb.slack.com/archives/C06UEMLK7FE/p1713380092262789
Summary of changes
As a quick fix, we effectively disable this check while we figure out how to inhibit image layer creation check
more gracefully. If it turns out that the solution shouldn't be wal based, we'll gracefully deprecate the config.