Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver/config: disable image layer creation check threshold #7414

Closed

Conversation

VladLazar
Copy link
Contributor

@VladLazar VladLazar commented Apr 17, 2024

Problem

Christian diagnosed the compaction change in #7230 as the root cause for slow find_lsn_for_timestamp in prod.

The essence of the problem is that Timeline::last_image_layer_creation_check_at is updated after the first partition, causing all remaining ones to skip image layer creation.

Details: https://neondb.slack.com/archives/C06UEMLK7FE/p1713380092262789

Summary of changes

As a quick fix, we effectively disable this check while we figure out how to inhibit image layer creation check
more gracefully. If it turns out that the solution shouldn't be wal based, we'll gracefully deprecate the config.

@VladLazar VladLazar marked this pull request as ready for review April 17, 2024 19:56
@VladLazar VladLazar requested a review from a team as a code owner April 17, 2024 19:56
@VladLazar VladLazar requested a review from koivunej April 17, 2024 19:56
@problame problame requested review from problame and removed request for koivunej April 17, 2024 20:13
@problame
Copy link
Contributor

(Edited the PR description)

Copy link

2760 tests run: 2641 passed, 1 failed, 118 skipped (full report)


Failures on Postgres 15

  • test_auth_failures[True]: debug
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_auth_failures[debug-pg15-True]"

Test coverage report is not available

The comment gets automatically updated with the latest test results
bea69ef at 2024-04-17T20:30:34.887Z :recycle:

@VladLazar
Copy link
Contributor Author

Should probably close this in favour of https://github.com/neondatabase/aws/pull/1270 and implement a proper fix.

@VladLazar
Copy link
Contributor Author

Closing in favour of proper fix: #7420

@VladLazar VladLazar closed this Apr 18, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants