pageserver/http: remove status code boilerplate from swagger spec

[VladLazar]

Problem

We specify a bunch of possible error codes in the pageserver api swagger spec. This is error prone and annoying to work with. https://github.com/neondatabase/cloud/pull/11907 introduced generic error handling on the control plane side, so we can now clean up the spec.

Summary of changes

• Remove generic error codes from swagger spec
• Update a couple route handlers which would previously return an error without a msg field in the response body.

Tested via https://github.com/neondatabase/cloud/pull/12340

Related https://github.com/neondatabase/cloud/issues/7238

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.
• Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
• If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

• Do not forget to reformat commit message to not include the above checklist

[github-actions]

2760 tests run: 2642 passed, 0 failed, 118 skipped (full report)

---

Flaky tests (1)

Postgres 14

• test_timeline_size_quota_on_startup: release

Code coverage* (full report)

• functions: 28.0% (6436 of 23016 functions)
• lines: 46.5% (45060 of 96831 lines)

* collected from Rust tests only

---

_{The comment gets automatically updated with the latest test results
ce6703e at 2024-04-16T10:01:11.774Z :recycle:}

[jcsp]

Tested via https://github.com/neondatabase/cloud/pull/12340

Thanks for doing that.

@mtyazici if the control plane compiles and e2e tests pass, does that give us a good certainty that the removed error codes won't cause issues? I'm thinking especially of the 409/412 cases that might be explicitly used in some logic somewhere.

[VladLazar]

Tested via neondatabase/cloud#12340

Thanks for doing that.

@mtyazici if the control plane compiles and e2e tests pass, does that give us a good certainty that the removed error codes won't cause issues? I'm thinking especially of the 409/412 cases that might be explicitly used in some logic somewhere.

There's some failures on https://github.com/neondatabase/cloud/pull/12340. Trying to disentangle test flakiness from the change.

[mtyazici]

@mtyazici if the control plane compiles and e2e tests pass, does that give us a good certainty that the removed error codes won't cause issues? I'm thinking especially of the 409/412 cases that might be explicitly used in some logic somewhere.

I now see we retry on any error when checking for 404 on resource deletion instead of 409/412. Could be better to fix that logic as well if it's better.

There's some failures on https://github.com/neondatabase/cloud/pull/12340. Trying to disentangle test flakiness from the change.

Failures seem to be related to how PR is titled, the tests are passing which shows there is no actual problem.

[VladLazar]

Failures seem to be related to how PR is titled, the tests are passing which shows there is no actual problem.

I retriggered the tests and they passed. Likely just flakes.

[VladLazar]

Tests are passing on https://github.com/neondatabase/cloud/pull/12340. I think we should be ok to merge.