Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute hook: use shared client with explicit timeout #7359

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Apr 11, 2024

Problem

We are seeing some mysterious long waits when sending requests.

Summary of changes

  • To eliminate risk that we are incurring some unreasonable overheads from setup, e.g. DNS, use a single Client (internally a pool) instead of repeatedly constructing a fresh one.
  • To make it clearer where a timeout is occurring, apply a 10 second timeout to requests as we send them.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added a/tech_debt Area: related to tech debt c/storage/controller Component: Storage Controller labels Apr 11, 2024
@jcsp jcsp requested a review from a team as a code owner April 11, 2024 11:40
Copy link

github-actions bot commented Apr 11, 2024

2754 tests run: 2636 passed, 0 failed, 118 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_ts_of_lsn_api: debug

Code coverage* (full report)

  • functions: 28.1% (6429 of 22866 functions)
  • lines: 46.8% (45140 of 96404 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
69e1c64 at 2024-04-11T14:27:41.242Z :recycle:

@jcsp jcsp enabled auto-merge (squash) April 11, 2024 14:02
@jcsp jcsp merged commit 1628b5b into main Apr 11, 2024
60 of 61 checks passed
@jcsp jcsp deleted the jcsp/refine-hook-client branch April 11, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/controller Component: Storage Controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants