Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: reinstate some syntethic size tests #7294

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

VladLazar
Copy link
Contributor

@VladLazar VladLazar commented Apr 3, 2024

Problem

test_empty_tenant_size was marked xfail and a few other tests were skipped.

Summary of changes

Stabilise test_empty_tenant_size. This test attempted to disable checkpointing for the postgres instance
and expected that the synthetic size remains stable for an empty tenant. When debugging I noticed that
postgres was issuing a checkpoint after the transaction in the test (perhaps something changed since the
test was introduced). Hence, I relaxed the size check to allow for the checkpoint key written on the pageserver.

Also removed the checks for synthetic size inputs since the expected values differ between postgres versions.

Closes #7138

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Apr 3, 2024

2748 tests run: 2624 passed, 0 failed, 124 skipped (full report)


Code coverage* (full report)

  • functions: 27.9% (6382 of 22848 functions)
  • lines: 46.8% (44992 of 96049 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
c2cb843 at 2024-04-04T09:59:35.586Z :recycle:

@VladLazar
Copy link
Contributor Author

test_empty_tenant_size is writing a checkpoint key after the initial size is fetched. Looking into where that's coming from.

@VladLazar
Copy link
Contributor Author

Stabilised test_empty_tenant_size and did 50 repeats on all other previously skipped tests (report). Looking good.

@VladLazar VladLazar requested review from koivunej and jcsp April 4, 2024 09:17
@VladLazar VladLazar marked this pull request as ready for review April 4, 2024 09:18
@VladLazar VladLazar changed the title wip: reinstate some syntethic size tests tests: reinstate some syntethic size tests Apr 4, 2024
Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I like the explanation.

@VladLazar VladLazar enabled auto-merge (squash) April 4, 2024 09:35
@VladLazar VladLazar merged commit c5f64fe into main Apr 4, 2024
48 of 49 checks passed
@VladLazar VladLazar deleted the vlad/syntethic-size-tests branch April 4, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: reinstate synthetic size tests
2 participants