-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: copy delta layer prefix or "truncate" #7228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
commented
Mar 25, 2024
koivunej
commented
Mar 25, 2024
koivunej
commented
Mar 25, 2024
koivunej
commented
Mar 25, 2024
koivunej
commented
Mar 25, 2024
2760 tests run: 2642 passed, 0 failed, 118 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
377f5ca at 2024-04-17T09:38:59.817Z :recycle: |
koivunej
commented
Mar 27, 2024
VladLazar
approved these changes
Mar 28, 2024
koivunej
commented
Apr 4, 2024
VladLazar
approved these changes
Apr 4, 2024
also fix the file documentation which did have me confused with the ordering.
koivunej
force-pushed
the
truncate_delta
branch
from
April 16, 2024 13:10
ef3b2f9
to
cca760f
Compare
also, missed the other discriminator bytes.
VladLazar
approved these changes
Apr 17, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For "timeline ancestor merge" or "timeline detach," we need to "cut" delta layers at particular LSN. The name "truncate" is not used as it would imply that a layer file changes, instead of what happens: we copy keys with Lsn less than a "cut point".
Cc: #6994
Summary of changes
Add the "copy delta layer prefix" operation to DeltaLayerInner, re-using some of the vectored read internals. The code is
cfg(test)
until it will be used later with a more complete integration test.