Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy delta layer prefix or "truncate" #7228

Merged
merged 7 commits into from
Apr 18, 2024
Merged

feat: copy delta layer prefix or "truncate" #7228

merged 7 commits into from
Apr 18, 2024

Conversation

koivunej
Copy link
Member

Problem

For "timeline ancestor merge" or "timeline detach," we need to "cut" delta layers at particular LSN. The name "truncate" is not used as it would imply that a layer file changes, instead of what happens: we copy keys with Lsn less than a "cut point".

Cc: #6994

Summary of changes

Add the "copy delta layer prefix" operation to DeltaLayerInner, re-using some of the vectored read internals. The code is cfg(test) until it will be used later with a more complete integration test.

@koivunej koivunej requested a review from VladLazar March 25, 2024 14:50
@koivunej koivunej requested a review from a team as a code owner March 25, 2024 14:50
Copy link

github-actions bot commented Mar 25, 2024

2760 tests run: 2642 passed, 0 failed, 118 skipped (full report)


Code coverage* (full report)

  • functions: 28.1% (6475 of 23065 functions)
  • lines: 46.8% (45603 of 97424 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
377f5ca at 2024-04-17T09:38:59.817Z :recycle:

also, missed the other discriminator bytes.
@koivunej koivunej merged commit 8d0f701 into main Apr 18, 2024
52 of 53 checks passed
@koivunej koivunej deleted the truncate_delta branch April 18, 2024 07:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants