-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy: connect redis with AWS IAM #7189
Conversation
2706 tests run: 2574 passed, 0 failed, 132 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
5d5cc34 at 2024-03-21T13:56:47.891Z :recycle: |
…sa-auth-for-elasticache
Code is rather complex but it seems ok. I don't see anything inherently wrong. How do we plan to roll this out safely? |
Right now we don't have regional redis anywhere except the preview (and even with the preview it's a bit tricky). Once we have setup on staging, we could enable it there. For now I suggest the following plan:
|
This reverts commit 6770ddb.
Problem
Support of IAM Roles for Service Accounts for authentication.
Summary of changes
TODOs:
Credentials obtaining and connection refresh was tested on xenon preview.
https://github.com/neondatabase/cloud/issues/10365
Checklist before requesting a review
Checklist before merging