Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: disable neon extension auto upgrade #7128

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Mar 14, 2024

Problem

This pull request disables neon extension auto upgrade to help the next compute image upgrade smooth.

Summary of changes

We have two places to auto-upgrade neon extension: during compute spec update, and when the compute node starts. The compute spec update logic is always there, and the compute node start logic is added in #7029. In this pull request, we disable both of them, so that we can still roll back to an older version of compute before figuring out the best way of extension upgrade-downgrade. #6936

We will enable auto-upgrade in the next release following this release.

There are no other extension upgrades from release 4917 and therefore after this pull request, it would be safe to revert to release 4917.

Impact:

  • Project created after unpinning the compute image -> if we need to roll back, they will stuck, because the default neon extension version is 1.3. Need to manually pin the compute image version if such things happen.
  • Projects already stuck on staging due to not downgradeable -> I don't know their current status, maybe they are already running the latest compute image? They are already pinned to release-5037 and we should not change the pinning status of these projects.
  • Other projects -> can be rolled back to release 4917.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested review from a team as code owners March 14, 2024 14:22
@skyzh
Copy link
Member Author

skyzh commented Mar 14, 2024

Release plan:

  • Release this image so that everyone has downgrade script, and release the week after next week to upgrade everyone to 1.3.
  • For compute nodes not waking up during the following week between {this downgradeable relese, next upgrade release}, they might be stuck. Need run check_availability on all existing computes.

@skyzh skyzh enabled auto-merge (squash) March 14, 2024 14:30
@skyzh skyzh mentioned this pull request Mar 14, 2024
Copy link

2652 tests run: 2528 passed, 0 failed, 124 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_ondemand_activation: debug

Code coverage* (full report)

  • functions: 28.4% (7032 of 24719 functions)
  • lines: 47.2% (43469 of 92116 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2d2d6fa at 2024-03-14T15:07:15.269Z :recycle:

@skyzh skyzh merged commit 76c44dc into main Mar 14, 2024
53 checks passed
@skyzh skyzh deleted the skyzh/disable-auto-upgrade branch March 14, 2024 19:45
skyzh added a commit that referenced this pull request Mar 25, 2024
skyzh added a commit that referenced this pull request Mar 28, 2024
reverts #7128, unblocks
neondatabase/cloud#10742

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants