Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throttling: exclude throttled time from basebackup (fixup of #6953) #7072

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

problame
Copy link
Contributor

@problame problame commented Mar 8, 2024

PR #6953 only excluded throttled time from the handle_pagerequests
(aka smgr metrics).

This PR implements the deduction for basebackup queries.

The other page_service methods either don't use Timeline::get
or they aren't used in production.

Found by manually inspecting in staging logs.

PR #6953 only excluded throttled time from the handle_pagerequests
(aka smgr metrics).

This PR implements the deduction for `basebackup ` queries.

The other page_service methods either don't use Timeline::get
or they aren't used in production.
@problame problame requested review from jcsp and koivunej and removed request for jcsp March 8, 2024 19:10
@problame problame marked this pull request as ready for review March 8, 2024 19:16
@problame problame requested a review from a team as a code owner March 8, 2024 19:16
@problame problame requested review from arpad-m and removed request for arpad-m March 8, 2024 19:16
Copy link

github-actions bot commented Mar 8, 2024

2490 tests run: 2370 passed, 0 failed, 120 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_compute_pageserver_connection_stress: debug

Code coverage* (full report)

  • functions: 28.8% (7037 of 24445 functions)
  • lines: 47.6% (43469 of 91361 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
de596b3 at 2024-03-08T19:52:33.402Z :recycle:

@problame problame merged commit 74d2458 into main Mar 9, 2024
54 checks passed
@problame problame deleted the problame/throttling-fix-basebackup-metrics branch March 9, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants