Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: fix bug with populating the data #7023

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Mar 5, 2024

Problem

Branch/project and coldStart were not populated to data events.

Summary of changes

Populate it. Also added logging for the coldstart info.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova requested a review from a team as a code owner March 5, 2024 14:14
@khanova khanova changed the title Fix project config. proxy: fix bug with populating the data Mar 5, 2024
@khanova khanova enabled auto-merge (squash) March 5, 2024 15:02
Copy link

github-actions bot commented Mar 5, 2024

2490 tests run: 2367 passed, 0 failed, 123 skipped (full report)


Code coverage* (full report)

  • functions: 28.8% (6982 of 24246 functions)
  • lines: 47.4% (42871 of 90518 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
7c195e8 at 2024-03-05T15:21:57.195Z :recycle:

@khanova khanova merged commit 15b3665 into main Mar 5, 2024
56 of 86 checks passed
@khanova khanova deleted the proxy-populate-branch-project-and-coldstart branch March 5, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants