Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: handle temp_download files in secondary locations #6990

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Mar 1, 2024

Problem

PR #6837 fixed secondary locations to avoid spamming log warnings on temp files, but we also have ".temp_download" files to consider.

Summary of changes

  • Give temp_download files the same behavior as temp files.
  • Refactor the relevant helper to pub(crate) from pub

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Mar 1, 2024
@jcsp jcsp requested a review from a team as a code owner March 1, 2024 15:03
@jcsp jcsp requested a review from koivunej March 1, 2024 15:03
Copy link

github-actions bot commented Mar 1, 2024

2472 tests run: 2349 passed, 0 failed, 123 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_timeline_size_quota_on_startup: release

Code coverage* (full report)

  • functions: 28.8% (6930 of 24085 functions)
  • lines: 47.4% (42552 of 89856 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
93079c2 at 2024-03-01T15:42:27.415Z :recycle:

@jcsp jcsp merged commit d999c46 into main Mar 1, 2024
56 checks passed
@jcsp jcsp deleted the jcsp/secondary-temp-download branch March 1, 2024 16:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants