Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: mention key in walredo errors #6988

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Mar 1, 2024

Problem

  • Walredo errors, e.g. during image creation, mention the LSN affected but not the key.

Summary of changes

  • Add key to "error applying ... WAL records" log message

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Mar 1, 2024
@jcsp jcsp requested a review from a team as a code owner March 1, 2024 14:40
@jcsp jcsp requested a review from VladLazar March 1, 2024 14:40
Copy link

github-actions bot commented Mar 1, 2024

2460 tests run: 2337 passed, 0 failed, 123 skipped (full report)


Flaky tests (4)

Postgres 16

  • test_vm_bit_clear_on_heap_lock: debug

Postgres 14

  • test_wal_page_boundary_start: release
  • test_neon_superuser: debug
  • test_empty_tenant_size: release

Code coverage* (full report)

  • functions: 28.8% (6932 of 24085 functions)
  • lines: 47.4% (42558 of 89856 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
0751821 at 2024-03-04T09:10:38.249Z :recycle:

Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally enjoy the key in this context. From the spans created by page_service and the output of walredo we already have the postgres "format", this would remove another step in debugging.

Checked that the Key has a good Display.

pageserver/src/walredo.rs Show resolved Hide resolved
@jcsp jcsp enabled auto-merge (squash) March 1, 2024 16:19
@jcsp jcsp merged commit fad9be4 into main Mar 4, 2024
56 checks passed
@jcsp jcsp deleted the jcsp/walredo-log-key branch March 4, 2024 08:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants