Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): drop subscription when test completes #6975

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Feb 29, 2024

Problem

This pull request mitigates #6969, but the longer-term problem is that we cannot properly stop Postgres if there is a subscription.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Feb 29, 2024

2490 tests run: 2368 passed, 0 failed, 122 skipped (full report)


Flaky tests (4)

Postgres 16

  • test_logical_replication: release
  • test_timeline_deletion_with_files_stuck_in_upload_queue: debug
  • test_empty_tenant_size: release

Postgres 14

  • test_pg_regress[4]: debug

Code coverage* (full report)

  • functions: 28.8% (6982 of 24255 functions)
  • lines: 47.4% (42878 of 90535 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
94005ce at 2024-03-06T16:06:09.961Z :recycle:

@skyzh skyzh marked this pull request as ready for review February 29, 2024 19:15
@save-buffer
Copy link
Contributor

It's strange that test_logical_replication doesn't have this issue

@knizhnik
Copy link
Contributor

It's strange that test_logical_replication doesn't have this issue

test_logical_replication use Vanilla Postgres as subscriber

Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh
Copy link
Member Author

skyzh commented Mar 5, 2024

Per discussion at the compute meeting, we can mitigate this issue first by dropping the replication subscription and look into the root cause later. @save-buffer would you please take a look? Thanks a lot!

Copy link
Contributor

@save-buffer save-buffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this one out. Did we ever figur eout why it was only pg15?

@skyzh
Copy link
Member Author

skyzh commented Mar 5, 2024

I have no idea, and we still need to investigate the root cause in the future 😅

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh enabled auto-merge (squash) March 6, 2024 15:26
@skyzh skyzh merged commit 5dc2088 into main Mar 6, 2024
53 checks passed
@skyzh skyzh deleted the skyzh/drop-subscription branch March 6, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants