-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): drop subscription when test completes #6975
Conversation
2490 tests run: 2368 passed, 0 failed, 122 skipped (full report)Flaky tests (4)Postgres 16
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
94005ce at 2024-03-06T16:06:09.961Z :recycle: |
a5c4333
to
ebf0eab
Compare
It's strange that |
test_logical_replication use Vanilla Postgres as subscriber |
Signed-off-by: Alex Chi Z <chi@neon.tech>
ebf0eab
to
5130cea
Compare
Signed-off-by: Alex Chi Z <chi@neon.tech>
Per discussion at the compute meeting, we can mitigate this issue first by dropping the replication subscription and look into the root cause later. @save-buffer would you please take a look? Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for figuring this one out. Did we ever figur eout why it was only pg15?
I have no idea, and we still need to investigate the root cause in the future 😅 |
Signed-off-by: Alex Chi Z <chi@neon.tech>
Problem
This pull request mitigates #6969, but the longer-term problem is that we cannot properly stop Postgres if there is a subscription.
Summary of changes
Checklist before requesting a review
Checklist before merging