Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage controller: include stripe size in compute notifications #6974

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Feb 29, 2024

Problem

  • The storage controller is the source of truth for a tenant's stripe size, but doesn't currently have a way to propagate that to compute: we're just using the default stripe size everywhere.

Closes: #6903

Summary of changes

  • Include stripe size in ComputeHookNotifyRequest
  • Include stripe size in LocationConfigResponse

The stripe size is optional: it will only be advertised for multi-sharded tenants. This enables the controller to defer the choice of stripe size until we split a tenant for the first time.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added t/feature Issue type: feature, for new features or requests c/storage/pageserver Component: storage: pageserver c/storage/controller Component: Storage Controller labels Feb 29, 2024
@jcsp jcsp requested a review from a team as a code owner February 29, 2024 17:28
@jcsp jcsp requested a review from problame February 29, 2024 17:28
Copy link

github-actions bot commented Feb 29, 2024

2490 tests run: 2366 passed, 0 failed, 124 skipped (full report)


Flaky tests (2)

Postgres 15

  • test_empty_branch_remote_storage_upload: release

Postgres 14

  • test_compute_pageserver_connection_stress: release

Code coverage* (full report)

  • functions: 28.8% (6993 of 24258 functions)
  • lines: 47.4% (43020 of 90680 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4344e52 at 2024-03-06T11:36:49.914Z :recycle:

@jcsp jcsp enabled auto-merge (squash) March 1, 2024 16:49
@jcsp jcsp requested a review from VladLazar March 1, 2024 19:40
control_plane/attachment_service/src/compute_hook.rs Outdated Show resolved Hide resolved
control_plane/src/bin/neon_local.rs Show resolved Hide resolved
pageserver/src/tenant.rs Show resolved Hide resolved
@jcsp jcsp merged commit 4a31e18 into main Mar 6, 2024
53 checks passed
@jcsp jcsp deleted the jcsp/notify-stripe-size branch March 6, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/controller Component: Storage Controller c/storage/pageserver Component: storage: pageserver t/feature Issue type: feature, for new features or requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage controller: expose stripe size in compute hook notifications
4 participants