Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /terminate API (#6745) #6853

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

nikitakalyanov
Copy link
Contributor

this is to speed up suspends, see
https://github.com/neondatabase/cloud/issues/10284

Cherry-pick to release branch to build new compute images

Problem

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Problem

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

this is to speed up suspends, see
neondatabase/cloud#10284

## Problem

## Summary of changes

## Checklist before requesting a review

- [ ] I have performed a self-review of my code.
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Do we need to implement analytics? if so did you add the relevant
metrics to the dashboard?
- [ ] If this PR requires public announcement, mark it with
/release-notes label and add several sentences in this section.

## Checklist before merging

- [ ] Do not forget to reformat commit message to not include the above
checklist
@nikitakalyanov nikitakalyanov requested review from a team as code owners February 21, 2024 10:23
@nikitakalyanov nikitakalyanov requested review from knizhnik, arpad-m and NanoBjorn and removed request for a team February 21, 2024 10:23
Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrote some nits before understanding this might be needed fast, so feel free to ignore them.

I cannot see any obvious problems.

compute_tools/src/http/api.rs Show resolved Hide resolved
compute_tools/src/http/api.rs Show resolved Hide resolved
compute_tools/src/http/api.rs Show resolved Hide resolved
Copy link

2442 tests run: 2325 passed, 0 failed, 117 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_vm_bit_clear_on_heap_lock: debug

Code coverage (full report)

  • functions: 55.8% (12930 of 23173 functions)
  • lines: 82.5% (69938 of 84785 lines)

The comment gets automatically updated with the latest test results
0e9985e at 2024-02-21T11:25:15.960Z :recycle:

@nikitakalyanov nikitakalyanov merged commit 96a4e8d into release Feb 22, 2024
46 of 47 checks passed
@nikitakalyanov nikitakalyanov deleted the nikitakalyanov/rc-2024-02-21 branch February 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants