Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: ensure startup params are properly forwarded to compute #6591

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

conradludgate
Copy link
Contributor

Problem

#1287 proxy does not forward all params to compute

Summary of changes

  • refactor startup messages to have less small allocs

actual solution: todo, will open a PR in rust-postgres fork

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Feb 2, 2024

2382 tests run: 2268 passed, 0 failed, 114 skipped (full report)


Flaky tests (3)

Postgres 15

  • test_crafted_wal_end[last_wal_record_crossing_segment]: release
  • test_sharding_service_smoke: debug

Postgres 14

Code coverage (full report)

  • functions: 54.6% (11286 of 20678 functions)
  • lines: 81.6% (63640 of 77951 lines)

The comment gets automatically updated with the latest test results
db7b244 at 2024-02-02T19:28:26.137Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant