Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control_plane/attachment_service: make --path optional #6545

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Jan 31, 2024

Problem

The --path argument is only used in testing, for compat tests that use a JSON snapshot of state rather than the postgres database. In regular deployments, it should be omitted (currently one has to specify --path "")

Summary of changes

Make --path optional.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added a/tech_debt Area: related to tech debt c/storage Component: storage labels Jan 31, 2024
Copy link

github-actions bot commented Jan 31, 2024

2376 tests run: 2283 passed, 0 failed, 93 skipped (full report)


Flaky tests (2)

Postgres 16

Postgres 15

Code coverage (full report)

  • functions: 54.6% (11226 of 20569 functions)
  • lines: 81.6% (62982 of 77217 lines)

The comment gets automatically updated with the latest test results
5ddc597 at 2024-01-31T16:21:27.609Z :recycle:

@jcsp jcsp requested a review from arpad-m January 31, 2024 13:16
@jcsp jcsp marked this pull request as ready for review January 31, 2024 13:16
@jcsp jcsp requested review from a team as code owners January 31, 2024 13:16
@jcsp jcsp requested review from conradludgate and removed request for a team and conradludgate January 31, 2024 13:16
control_plane/attachment_service/src/main.rs Outdated Show resolved Hide resolved
@jcsp jcsp enabled auto-merge (squash) January 31, 2024 13:56
@jcsp jcsp merged commit 2bfc831 into main Jan 31, 2024
47 checks passed
@jcsp jcsp deleted the jcsp/storage-controller-optional-path branch January 31, 2024 17:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage Component: storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants