disk_usage_eviction_task: cleanup summaries #6490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2024
2340 tests run: 2247 passed, 0 failed, 93 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
be49c13 at 2024-01-29T08:19:23.636Z :recycle: |
jcsp
approved these changes
Jan 26, 2024
|
👍 You might need to re-push this one to get the fix for the compute image build failure from this morning. |
|
I also have the coverage failure (AGAIN), didn't notice the compute image. |
koivunej
force-pushed
the
next_duab_step
branch
from
688e747
to
6bfaf25
Compare
koivunej
force-pushed
the
next_duab_step
branch
from
6bfaf25
to
be49c13
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the "partial revert" of #6384. The summaries turned out to be expensive due to naive vec usage, but also inconclusive because of the additional context required. In addition to removing summary traces, small refactoring is done.