-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pageserver: implement emergency mode for operating without control plane #5469
Conversation
7d2f570
to
dfa6f41
Compare
dfa6f41
to
acd84d7
Compare
2256 tests run: 2140 passed, 0 failed, 116 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
a548284 at 2023-10-06T11:36:29.639Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to catch anything higher level than the span usage, timeouting tests with the many layers being generated (I guess mock_s3 can get slow -- it's the python impl).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I now understood it. I don't necessarily like the ordering or structuring but unable to suggest a better one. This was split from some other PR so let's hope it'll reorder :)
Problem
Pageservers with
control_plane_api
configured require a control plane to start up: in an incident this might be a problem.Summary of changes
Note to reviewers: most of the code churn in mgr.rs is the refactor commit that enables the later emergency mode commit: you may want to review commits separately.
control_plane_emergency_mode
configuration propertyCloses: #5381
Closes: #5492