Release 2023-09-26 #5375
Merged
Release 2023-09-26 #5375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#5332) ## Problem See https://neondb.slack.com/archives/C05L7D1JAUS/p1693775881474019 ## Summary of changes Do not perform local file cache resizing in processes having no PGPROC ## Checklist before requesting a review - [ ] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard? - [ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section. ## Checklist before merging - [ ] Do not forget to reformat commit message to not include the above checklist --------- Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
## Problem In 83e7e5d dependencies were only updated for Mac users. Without libicu, postgres 16 build fails. ## Summary of changes Update dependencies on Ubuntu and fedora to include libicu.
I used this while investigating a production issue, and seems like it could come handy in the future, too.
## Problem Before releasing new version to production, we'd like to run a set of required checks on the incoming release. The simplest approach, which doesn't require many changes — dedicate one staging region to `preprod` installation. The proposed changes to the release flow are the following: - When a release PR is merged into the release branch — trigger deployment from the release branch to a dedicated staging-preprod region (for now, it's going to be `eu-west-1` — Ireland) Corresponding infrastructure PR: neondatabase/infra#585 ## Summary of changes - Trigger `deploy.dev` workflow with `-f deployPreprodRegion=true` for release branch
## Problem Do not allow new installation of deprecated `hnsw` extension. The same approach as in #5345 ## Summary of changes - Remove `trusted = true` from `hnsw.control` - Remove `hnsw` related targets from Makefile
…nd quicker retries (#5358) ## Problem Compute start time has improved, but the timing of connection retries from the proxy is rather slow, meaning we could be making clients wait hundreds of milliseconds longer than necessary. ## Summary of changes Previously, retry time in ms was `100 * 1.5**n`, and `n` starts at 1, giving: 150, 225, 337, 506, 759, 1139, 1709, ... This PR changes that to `25 * sqrt(2)**(n - 1)` instead, giving: 25, 35, 50, 71, 100, 141, 200, ...
This PR adds a `task_kind` label to page cache access metrics. These are to validate our hypothesis that the high hit page cache rate we observe in prod is due to internal tasks, not getpage requests from compute. We believe the latter should near-always be a pageserver-page-cache _miss_ because compute has it's own page cache, and hence there is no locality of reference for its accesses to pageserver page cache. Before this PR, we didn't have `RequestContext` propagation to any code below the on-demand downloader. The vast majority of changes in this PR is concerned with adding that propagation.
Should have added them in the initial PR #5186. Would have been nice to test the failure cases as well, but, without mocking the FS, that's too hard / platform-dependent.
This only includes the changes from neondatabase/autoscaling#525, which improves graceful VM shutdown.
## Problem See https://neondb.slack.com/archives/C033RQ5SPDH/p1694595347598249 ## Summary of changes Update last written LSN after walloging all createdb stuff ## Checklist before requesting a review - [ ] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard? - [ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section. ## Checklist before merging - [ ] Do not forget to reformat commit message to not include the above checklist --------- Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
The TaskKind dimension added in #5339 is insufficient to understand what kind of data causes the cache hits. Regarding performance considerations: I'm not too worried because we're moving from 3 to 4 one-byte sized fields; likely the space now used by the new field was padding before. Didn't check this, though, and it doesn't matter, we need the data. What I don't like about this PR is that we have an `Unknown` content type, and I also don't like that there's no compile-time way to assert that it's set to something != `Unknown` when calling the page cache. But, this is what I could come up with before tomorrow’s release, and I think it covers the hot paths.
vipvap
requested review from
conradludgate and
problame
and removed request for
a team
![arnica-github-connector[bot]](https://github.com/avatars/in/144692?s=60&v=4){kind=small}
conradludgate
approved these changes
Sep 26, 2023
2496 tests run: 2378 passed, 0 failed, 118 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
3322b6c at 2023-09-26T07:36:31.577Z :recycle: |
koivunej
approved these changes
Sep 26, 2023
|
Release note: neondatabase/website#1042 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 2023-09-26
Please merge this PR using 'Create a merge commit'!