Update control plane API path for getting compute spec. #5357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlinnaka
requested review from
bojanserafimov and
antonyc
and removed request for
a team and
bojanserafimov
2340 tests run: 2223 passed, 0 failed, 117 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
c685e73 at 2023-11-01T17:32:58.373Z :recycle: |
ololobus
approved these changes
Oct 4, 2023
We changed the path in the control plane. The old path is still accepted for compatibility with existing computes, but we'd like to phase it out.
ololobus
force-pushed
the
update-cp-api-path
branch
from
3176178
to
c685e73
Compare
|
@hlinnaka let's merge this PR? I rebased it and e2e still passed well. Or do you remember any blockers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the path in the control plane. The old path is still accepted for compatibility with existing computes, but we'd like to phase it out.