Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm-monitor: Don't set cgroup memory.max #5333

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

sharnoff
Copy link
Member

All it does is make postgres OOM more often (which, tbf, means we're less likely to have e.g. compute_ctl get OOM-killed, but that tradeoff isn't worth it).

Internally, this means removing all references to memory.max and the places where we calculate or store the intended value.

As discussed in the sync earlier.

ref:

All it does is make postgres OOM more often (which, tbf, means we're
less likely to have e.g. compute_ctl get OOM-killed, but that tradeoff
isn't worth it)
@sharnoff sharnoff requested review from a team as code owners September 18, 2023 16:56
@sharnoff sharnoff enabled auto-merge (squash) September 18, 2023 16:58
@github-actions
Copy link

github-actions bot commented Sep 18, 2023

2484 tests run: 2367 passed, 0 failed, 117 skipped (full report)


Flaky tests (7)

Postgres 16

Postgres 15

  • test_crafted_wal_end[last_wal_record_crossing_segment]: debug

Postgres 14

  • test_get_tenant_size_with_multiple_branches: release

Code coverage (full report)

  • functions: 53.0% (7749 of 14614 functions)
  • lines: 81.0% (45231 of 55824 lines)

The comment gets automatically updated with the latest test results
fad94f6 at 2023-09-18T18:31:23.001Z :recycle:

@sharnoff sharnoff merged commit 722e526 into main Sep 18, 2023
38 checks passed
@sharnoff sharnoff deleted the sharnoff/monitor-no-cgroup-memory.max branch September 18, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants