Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

approved-for-ci-run.yml: fix variable name and permissions #5307

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

bayandin
Copy link
Member

Problem

  • gh pr list fails with unknown argument "main"; please quote all values that have spaces due to using a variable with wrong name
  • permissions: write-all are too wide for the job

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this

@bayandin bayandin enabled auto-merge (squash) September 14, 2023 13:24
@github-actions
Copy link

github-actions bot commented Sep 14, 2023

2472 tests run: 2353 passed, 0 failed, 119 skipped (full report)


Flaky tests (4)

Postgres 16

Code coverage (full report)

  • functions: 53.0% (7667 of 14455 functions)
  • lines: 81.0% (44758 of 55282 lines)

The comment gets automatically updated with the latest test results
53ac760 at 2023-09-14T17:01:02.884Z :recycle:

@bayandin bayandin force-pushed the bayandin/better-approved-for-ci-run  branch from 716ed7d to 53ac760 Compare September 14, 2023 15:43
@bayandin bayandin merged commit bd36d1c into main Sep 14, 2023
42 checks passed
@bayandin bayandin deleted the bayandin/better-approved-for-ci-run  branch September 14, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants