Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CI_ACCESS_TOKEN to create release PR #5286

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

bayandin
Copy link
Member

Problem

If @github-actions creates release PR, the CI pipeline is not triggered (but we have release-notify.yml workflow that we expect to run on this event).
I suspect this happened because @github-actions is not a repository member.

Ref #5283 (comment)

Summary of changes

  • Use CI_ACCESS_TOKEN to create PR
  • Use gh instead of thomaseizinger/create-pull-request
  • Restrict permissions for GITHUB_TOKEN to contents: write only (required for git push)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@github-actions
Copy link

1644 tests run: 1570 passed, 0 failed, 74 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_download_remote_layers_api[local_fs]: release

Code coverage (full report)

  • functions: 53.0% (7582 of 14310 functions)
  • lines: 81.5% (44802 of 54966 lines)

The comment gets automatically updated with the latest test results
e06c406 at 2023-09-12T12:01:24.442Z :recycle:

@bayandin bayandin merged commit 2641ff3 into main Sep 12, 2023
37 checks passed
@bayandin bayandin deleted the bayandin/create-release-from-vipvap branch September 12, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants