Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

approved-for-ci-run.yml: fix ci-run/pr-* branch deletion #5278

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

bayandin
Copy link
Member

Problem

ci-run/pr-* branches (and attached PRs) should be deleted automatically when their parent PRs get closed.
But there are not

Summary of changes

  • Fix condition

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@github-actions
Copy link

1644 tests run: 1569 passed, 0 failed, 75 skipped (full report)


Flaky tests (2)

Postgres 14

  • test_download_remote_layers_api[local_fs]: release
  • test_get_tenant_size_with_multiple_branches: release

Code coverage (full report)

  • functions: 53.1% (7605 of 14334 functions)
  • lines: 81.4% (44751 of 54962 lines)

The comment gets automatically updated with the latest test results
7c966ef at 2023-09-11T15:05:12.206Z :recycle:

@bayandin bayandin enabled auto-merge (squash) September 12, 2023 15:53
@bayandin bayandin merged commit e1661c3 into main Sep 12, 2023
37 checks passed
@bayandin bayandin deleted the bayandin/fix-ci-branch-deletion branch September 12, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants