Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: locked is not retriable #5162

Merged
merged 2 commits into from
Aug 31, 2023
Merged

proxy: locked is not retriable #5162

merged 2 commits into from
Aug 31, 2023

Conversation

conradludgate
Copy link
Contributor

Problem

Management service returns Locked when quotas are exhausted. We cannot retry on those

Summary of changes

Makes Locked status unretriable

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate requested a review from a team as a code owner August 31, 2023 11:28
@conradludgate conradludgate enabled auto-merge (squash) August 31, 2023 11:29
@conradludgate
Copy link
Contributor Author

We should probably update this error message

http::StatusCode::LOCKED => {
// Status 423: project might be in maintenance mode (or bad state).
format!("{REQUEST_FAILED}: endpoint is temporary unavailable")
}

It's not very useful for the end user

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

1624 tests run: 1550 passed, 0 failed, 74 skipped (full report)


The comment gets automatically updated with the latest test results
9c3c885 at 2023-08-31T12:35:46.934Z :recycle:

@conradludgate conradludgate enabled auto-merge (squash) August 31, 2023 12:25
@conradludgate conradludgate merged commit 1b916a1 into main Aug 31, 2023
32 checks passed
@conradludgate conradludgate deleted the proxy/locked branch August 31, 2023 12:50
// Status 423: project might be in maintenance mode (or bad state).
format!("{REQUEST_FAILED}: endpoint is temporary unavailable")
// Status 423: project might be in maintenance mode (or bad state), or quotas exceeded.
format!("{REQUEST_FAILED}: endpoint is temporary unavailable. check your quotas and/or contract our support")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: contact should be

@conradludgate conradludgate mentioned this pull request Sep 1, 2023
5 tasks
conradludgate added a commit that referenced this pull request Sep 1, 2023
jcsp pushed a commit that referenced this pull request Sep 4, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants