Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use metrics to track lease usage #8120

Closed
Tracked by #7497
yliang412 opened this issue Jun 20, 2024 · 1 comment · Fixed by #8147
Closed
Tracked by #7497

Use metrics to track lease usage #8120

yliang412 opened this issue Jun 20, 2024 · 1 comment · Fixed by #8147
Assignees
@yliang412
Labels
c/storage/pageserver Component: storage: pageserver

Comments

@yliang412
Copy link
Contributor

yliang412 commented Jun 20, 2024 •
edited
Loading

Track how many leases are issued. Disk space can be also an indicator.
@yliang412 yliang412 mentioned this issue Jun 20, 2024
Open
@yliang412 yliang412 self-assigned this Jun 20, 2024
@yliang412 yliang412 added the c/storage/pageserver Component: storage: pageserver label Jun 20, 2024
@yliang412
Copy link
Contributor Author

This week: implementation

@yliang412 yliang412 mentioned this issue Jun 24, 2024
Merged
5 tasks
conradludgate pushed a commit that referenced this issue Jun 27, 2024
@yliang412 @conradludgate
feat(pageserver): add metrics for number of valid leases after each r…
e8b3aa5 
…efresh (#8147)

Part of #7497, closes #8120.

## Summary of changes

This PR adds a metric to track the number of valid leases after `GCInfo`
gets refreshed each time.

Besides this metric, we should also track disk space and synthetic size
(after #8071 is closed) to make sure leases are used properly.

Signed-off-by: Yuchen Liang <yuchen@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yliang412 yliang412

Labels
c/storage/pageserver Component: storage: pageserver
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pageserver): add metrics for number of valid leases after each refresh neondatabase/neon
1 participant
@yliang412