log errors in test_timeline_ancestor_errors
#7911
Labels
Comments
jcsp
added
c/storage/pageserver
5 tasks
jcsp
added a commit
that referenced
this issue
May 31, 2024
…7912) ## Problem - Initial size calculations tend to fail with `Bad state (not active)` Closes: #7911 ## Summary of changes - In `wait_lsn`, return WaitLsnError::Cancelled rather than BadState when the state is Stopping - Replace PageReconstructError's `Other` variant with a specific `BadState` variant - Avoid returning anyhow::Error from get_ready_ancestor_timeline -- this was only used for the case where there was no ancestor. All callers of this function had implicitly checked that the ancestor timeline exists before calling it, so they can pass in the ancestor instead of handling an error.
a-masterov
pushed a commit
that referenced
this issue
Jun 3, 2024
…7912) ## Problem - Initial size calculations tend to fail with `Bad state (not active)` Closes: #7911 ## Summary of changes - In `wait_lsn`, return WaitLsnError::Cancelled rather than BadState when the state is Stopping - Replace PageReconstructError's `Other` variant with a specific `BadState` variant - Avoid returning anyhow::Error from get_ready_ancestor_timeline -- this was only used for the case where there was no ancestor. All callers of this function had implicitly checked that the ancestor timeline exists before calling it, so they can pass in the ancestor instead of handling an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Example: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-7890/9289540753/index.html#/testresult/50cc44a543293a6d
The text was updated successfully, but these errors were encountered: