Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dummy lease API implementation #7808

Closed
Tracked by #7497
jcsp opened this issue May 20, 2024 · 0 comments · Fixed by #7815
Closed
Tracked by #7497

Implement dummy lease API implementation #7808

jcsp opened this issue May 20, 2024 · 0 comments · Fixed by #7815
Assignees
@arpad-m
Labels
c/storage/pageserver Component: storage: pageserver t/feature Issue type: feature, for new features or requests

Comments

@jcsp
Copy link
Contributor

jcsp commented May 20, 2024 •
edited
Loading

Part of:

API should return a structure describing the lease, especially how long it is valid for, so that caller knows when to re-acquire their lease.

This will basically be a few lines in page_service.rs to implement a new verb as a peer of basebackup, get page, etc.
@jcsp jcsp mentioned this issue May 20, 2024
Open
@jcsp jcsp added t/feature Issue type: feature, for new features or requests c/storage/pageserver Component: storage: pageserver labels May 20, 2024
@jcsp jcsp assigned jcsp and arpad-m and unassigned jcsp May 20, 2024
@jcsp jcsp changed the title Implement dummy lease API implementation to allow computectl integration to proceed: API should return a structure describing the lease, especially how long it is valid for, so that caller knows when to re-acquire their lease. Implement dummy lease API implementation May 20, 2024
@arpad-m arpad-m mentioned this issue May 20, 2024
Merged
arpad-m added a commit that referenced this issue May 21, 2024
@arpad-m @koivunej
Add dummy lsn lease http and page service APIs (#7815)
679e031 
We want to introduce a concept of temporary and expiring LSN leases.
This adds both a http API as well as one for the page service to obtain
temporary LSN leases.

This adds a dummy implementation to unblock integration work of this
API. A functional implementation of the lease feature is deferred to a
later step.

Fixes #7808

Co-authored-by: Joonas Koivunen <joonas@neon.tech>
This was referenced Jun 13, 2024
Closed
Merged
yliang412 added a commit that referenced this issue Jun 18, 2024
@yliang412
feat(pageserver): use leases to temporarily block gc (#8084)
30b890e 
Part of #7497, extracts from #7996, closes #8063.

## Problem

With the LSN lease API introduced in
#7808, we want to implement
the real lease logic so that GC will
keep all the layers needed to reconstruct all pages at all the leased
LSNs with valid leases at a given time.

Signed-off-by: Yuchen Liang <yuchen@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arpad-m arpad-m

Labels
c/storage/pageserver Component: storage: pageserver t/feature Issue type: feature, for new features or requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dummy lsn lease http and page service APIs neondatabase/neon
2 participants
@jcsp @arpad-m