Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics support for azure blob storage #5590

Closed
Tracked by #5567
arpad-m opened this issue Oct 18, 2023 · 3 comments · Fixed by #7933
Closed
Tracked by #5567

Metrics support for azure blob storage #5590

arpad-m opened this issue Oct 18, 2023 · 3 comments · Fixed by #7933
Labels
c/storage/pageserver Component: storage: pageserver c/storage/safekeeper Component: storage: safekeeper f/azure

Comments

@arpad-m
Copy link
Member

arpad-m commented Oct 18, 2023 •
edited
Loading

PR #5546 has added azure blob storage support but didn't implement metrics for them. We should ideally:

  • take the remote_storage::s3_bucket::metrics module and put it to the top level into remote_storage::metrics.
  • removing the s3 from the metric names like remote_storage_s3_request_seconds. This rename will need us to adjust our internal infrastructure to the rename.
  • using these metrics in the azure_blob module just like they are used in the s3_bucket module.

Part of #5567.
@arpad-m arpad-m added c/storage/safekeeper Component: storage: safekeeper c/storage/pageserver Component: storage: pageserver labels Oct 18, 2023
@arpad-m arpad-m mentioned this issue Oct 18, 2023
Closed
@arpad-m
Copy link
Member Author

arpad-m commented Oct 18, 2023

The approach I proposed above would also resolve this follow-up comment from @jcsp on my PR.

@arpad-m
Copy link
Member Author

arpad-m commented Nov 3, 2023 •
edited
Loading

I can work on the code side of things but I don't know much about the operations/collections side of it.

@arpad-m
Copy link
Member Author

arpad-m commented Nov 3, 2023

The affected metrics and searches across the neon org:

@arpad-m arpad-m mentioned this issue Jun 1, 2024
Merged
arpad-m added a commit that referenced this issue Jun 2, 2024
@arpad-m
Add metrics for Azure blob storage (#7933)
db477c0 
In issue #5590 it was proposed to implement metrics for Azure blob
storage. This PR implements them except for the part that performs the
rename, which is left for a followup.

Closes #5590
a-masterov pushed a commit that referenced this issue Jun 3, 2024
@arpad-m @a-masterov
Add metrics for Azure blob storage (#7933)
a70fea1 
In issue #5590 it was proposed to implement metrics for Azure blob
storage. This PR implements them except for the part that performs the
rename, which is left for a followup.

Closes #5590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/storage/pageserver Component: storage: pageserver c/storage/safekeeper Component: storage: safekeeper f/azure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add metrics for Azure blob storage neondatabase/neon
2 participants
@vadim2404 @arpad-m