Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the ways to handle with layer formats #3072

Closed
SomeoneToIgnore opened this issue Dec 12, 2022 · 1 comment
Closed

Merge the ways to handle with layer formats #3072

SomeoneToIgnore opened this issue Dec 12, 2022 · 1 comment
Labels
c/storage/pageserver Component: storage: pageserver

Comments

@SomeoneToIgnore
Copy link
Contributor

We have IndexLayerMetadata and IndexPart to manage similar things: remote storage file format.

We need to think of a unified, versioned way to handle this format.

See #3026 (comment) for the context
@SomeoneToIgnore SomeoneToIgnore added the c/storage/pageserver Component: storage: pageserver label Dec 12, 2022
@SomeoneToIgnore SomeoneToIgnore mentioned this issue Dec 12, 2022
Merged
@LizardWizzard
Copy link
Contributor

I would clarify. Its is only aboit index file format. Not the format for files themselves. Format for data files is the same as local one (since these are the same file essentially)

@jcsp jcsp closed this as completed Apr 26, 2024
@koivunej koivunej mentioned this issue May 23, 2024
Merged
koivunej added a commit that referenced this issue May 23, 2024
@koivunej
refactor(rtc): remove the duplicate IndexLayerMetadata (#7860)
7cf726e 
Once upon a time, we used to have duplicated types for runtime IndexPart
and whatever we stored. Because of the serde fixes in #5335 we have no
need for duplicated IndexPart type anymore, but the `IndexLayerMetadata`
stayed.

- remove the type
- remove LayerFileMetadata::file_size() in favor of direct field access

Split off from #7833. Cc: #3072.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/storage/pageserver Component: storage: pageserver
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcsp @SomeoneToIgnore @LizardWizzard