Skip to content

Commit

Permalink
tests: add a couple of allow lists for shutdown cases (#7844)
Browse files Browse the repository at this point in the history
## Problem

Failures on some of our uglier shutdown log messages:

https://neon-github-public-dev.s3.amazonaws.com/reports/main/9192662995/index.html#suites/07874de07c4a1c9effe0d92da7755ebf/51b365408678c66f/

## Summary of changes

- Allow-list these errors.
  • Loading branch information
jcsp committed May 22, 2024
1 parent 014f822 commit f98fdd2
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions test_runner/fixtures/pageserver/allowed_errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ def scan_pageserver_log_for_errors(
# this is expected given our collaborative shutdown approach for the UploadQueue
".*Compaction failed.*, retrying in .*: Other\\(queue is in state Stopped.*",
".*Compaction failed.*, retrying in .*: ShuttingDown",
".*Compaction failed.*, retrying in .*: timeline shutting down.*",
# Pageserver timeline deletion should be polled until it gets 404, so ignore it globally
".*Error processing HTTP request: NotFound: Timeline .* was not found",
".*took more than expected to complete.*",
Expand All @@ -91,6 +92,10 @@ def scan_pageserver_log_for_errors(
".*WARN deletion backend: calling control plane generation validation API failed.*error sending request.*",
# Can happen when the test shuts down the storage controller while it is calling the utilization API
".*WARN.*path=/v1/utilization .*request was dropped before completing",
# Can happen during shutdown
".*scheduling deletion on drop failed: queue is in state Stopped.*",
# Can happen during shutdown
".*ignoring failure to find gc cutoffs: timeline shutting down.*",
)


Expand Down

1 comment on commit f98fdd2

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3196 tests run: 3055 passed, 1 failed, 140 skipped (full report)


Failures on Postgres 16

  • test_ancestor_detach_branched_from[False-True-at]: debug
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_ancestor_detach_branched_from[debug-pg16-False-True-at]"

Test coverage report is not available

The comment gets automatically updated with the latest test results
f98fdd2 at 2024-05-22T19:58:10.506Z :recycle:

Please sign in to comment.