Skip to content

Commit

Permalink
CI(deploy): Do not deploy storage controller to preprod for proxy rel…
Browse files Browse the repository at this point in the history
…eases (#7269)

## Problem

Proxy release to a preprod automatically triggers a deployment of storage
controller (`deployStorageController=true` by default)

## Summary of changes
- Set `deployStorageController=false` for proxy releases to preprod
- Set explicitly `deployStorageController=true` for storage releases to
preprod and prod
  • Loading branch information
bayandin committed Mar 28, 2024
1 parent 722f271 commit c52b80b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1127,6 +1127,7 @@ jobs:
-f deployProxy=false \
-f deployStorage=true \
-f deployStorageBroker=true \
-f deployStorageController=true \
-f branch=main \
-f dockerTag=${{needs.tag.outputs.build-tag}} \
-f deployPreprodRegion=true
Expand All @@ -1136,6 +1137,7 @@ jobs:
-f deployProxy=false \
-f deployStorage=true \
-f deployStorageBroker=true \
-f deployStorageController=true \
-f branch=main \
-f dockerTag=${{needs.tag.outputs.build-tag}}
elif [[ "$GITHUB_REF_NAME" == "release-proxy" ]]; then
Expand All @@ -1144,6 +1146,7 @@ jobs:
-f deployProxy=true \
-f deployStorage=false \
-f deployStorageBroker=false \
-f deployStorageController=false \
-f branch=main \
-f dockerTag=${{needs.tag.outputs.build-tag}} \
-f deployPreprodRegion=true
Expand Down

1 comment on commit c52b80b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2822 tests run: 2668 passed, 3 failed, 151 skipped (full report)


Failures on Postgres 14

  • test_compute_auth_to_pageserver: debug
  • test_null_config: debug
  • test_basebackup_error: debug
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_compute_auth_to_pageserver[debug-pg14] or test_null_config[debug-pg14] or test_basebackup_error[debug-pg14]"

Test coverage report is not available

The comment gets automatically updated with the latest test results
c52b80b at 2024-03-28T18:03:07.834Z :recycle:

Please sign in to comment.