Skip to content

Commit

Permalink
compute_ctl: Fix unused variable on non-Linux (#7646)
Browse files Browse the repository at this point in the history
Introduced by refactorings from #7577.

See an example check-macos-build failure here:
https://github.com/neondatabase/neon/actions/runs/8992211409/job/24701531264
  • Loading branch information
sharnoff committed May 7, 2024
1 parent 26b1483 commit b827e7b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion compute_tools/src/bin/compute_ctl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,8 @@ struct WaitSpecResult {
}

fn start_postgres(
matches: &clap::ArgMatches,
// need to allow unused because `matches` is only used if target_os = "linux"
#[allow(unused_variables)] matches: &clap::ArgMatches,
WaitSpecResult {
compute,
http_port,
Expand Down

1 comment on commit b827e7b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3105 tests run: 2957 passed, 2 failed, 146 skipped (full report)


Failures on Postgres 14

  • test_heavy_write_workload[neon_off-github-actions-selfhosted-10-5-5]: release
  • test_storage_controller_many_tenants[github-actions-selfhosted]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_heavy_write_workload[neon_off-release-pg14-github-actions-selfhosted-10-5-5] or test_storage_controller_many_tenants[release-pg14-github-actions-selfhosted]"
Flaky tests (4)

Postgres 16

  • test_detached_receives_flushes_while_being_detached[True]: debug

Postgres 15

  • test_gc_aggressive: debug
  • test_vm_bit_clear_on_heap_lock: debug

Postgres 14

  • test_detached_receives_flushes_while_being_detached[True]: debug

Code coverage* (full report)

  • functions: 31.2% (6257 of 20054 functions)
  • lines: 46.7% (46933 of 100592 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b827e7b at 2024-05-08T00:18:45.599Z :recycle:

Please sign in to comment.