Skip to content

Commit

Permalink
Fix span for WAL removal task (#7930)
Browse files Browse the repository at this point in the history
During refactoring in #7887 I
forgot to add "WAL removal" span with ttid. This commit fixes it.
  • Loading branch information
petuhovskiy committed Jun 1, 2024
1 parent e98bc4f commit a345cf3
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions safekeeper/src/timeline_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use std::{

use postgres_ffi::XLogSegNo;
use tokio::task::{JoinError, JoinHandle};
use tracing::{info, instrument, warn};
use tracing::{info, info_span, instrument, warn, Instrument};
use utils::lsn::Lsn;

use crate::{
Expand Down Expand Up @@ -346,10 +346,13 @@ async fn update_wal_removal(
&tli.read_shared_state().await.sk.wal_store,
removal_horizon_segno,
);
*wal_removal_task = Some(tokio::spawn(async move {
remover.await?;
Ok(removal_horizon_segno)
}));
*wal_removal_task = Some(tokio::spawn(
async move {
remover.await?;
Ok(removal_horizon_segno)
}
.instrument(info_span!("WAL removal", ttid=%tli.ttid)),
));
}
}

Expand Down

1 comment on commit a345cf3

@github-actions
Copy link

@github-actions github-actions bot commented on a345cf3 Jun 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3394 tests run: 3241 passed, 1 failed, 152 skipped (full report)


Failures on Postgres 14

  • test_basebackup_with_high_slru_count[github-actions-selfhosted-sequential-10-13-30]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_basebackup_with_high_slru_count[release-pg14-github-actions-selfhosted-sequential-10-13-30]"
Flaky tests (3)

Postgres 16

  • test_delete_timeline_client_hangup: debug

Postgres 14

  • test_pageserver_restarts_under_worload: release
  • test_basebackup_with_high_slru_count[github-actions-selfhosted-sequential-10-13-30]: release

Code coverage* (full report)

  • functions: 31.4% (6532 of 20796 functions)
  • lines: 48.4% (50419 of 104274 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
a345cf3 at 2024-06-02T17:51:15.951Z :recycle:

Please sign in to comment.