Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use serde for RemoteStorageConfig parsing (#8126)
Adds a `Deserialize` impl to `RemoteStorageConfig`. We thus achieve the same as #7743 but with less repetitive code, by deriving `Deserialize` impls on `S3Config`, `AzureConfig`, and `RemoteStorageConfig`. The disadvantage is less useful error messages. The git history of this PR contains a state where we go via an intermediate representation, leveraging the `serde_json` crate, without it ever being actual json though. Also, the PR adds deserialization tests. Alternative to #7743 .
- Loading branch information
75747cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2998 tests run: 2871 passed, 1 failed, 126 skipped (full report)
Failures on Postgres 14
test_storage_controller_many_tenants[github-actions-selfhosted]
: releaseFlaky tests (3)
Postgres 15
test_subscriber_restart
: releasetest_wal_restore
: debugtest_wal_restore_initdb
: debugCode coverage* (full report)
functions
:32.4% (6869 of 21175 functions)
lines
:49.9% (53436 of 107076 lines)
* collected from Rust tests only
75747cd at 2024-06-22T19:25:53.263Z :recycle: