Use serde for RemoteStorageConfig parsing (#8126)

Adds a `Deserialize` impl to `RemoteStorageConfig`. We thus achieve the same as #7743 but with less repetitive code, by deriving `Deserialize` impls on `S3Config`, `AzureConfig`, and `RemoteStorageConfig`. The disadvantage is less useful error messages. The git history of this PR contains a state where we go via an intermediate representation, leveraging the `serde_json` crate, without it ever being actual json though. Also, the PR adds deserialization tests. Alternative to #7743 .
neondatabase · Jun 22, 2024 · 75747cd · 75747cd · github-actions · Jun 22, 2024
1 parent 8fe3f17
commit 75747cd
Show file tree

Hide file tree

Showing 8 changed files with 144 additions and 168 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/libs/remote_storage/Cargo.toml b/libs/remote_storage/Cargo.toml
@@ -14,8 +14,9 @@ aws-config.workspace = true
 aws-sdk-s3.workspace = true
 aws-credential-types.workspace = true
 bytes.workspace = true
-camino.workspace = true
+camino = { workspace = true, features = ["serde1"] }
 humantime.workspace = true
+humantime-serde.workspace = true
 hyper = { workspace = true, features = ["stream"] }
 futures.workspace = true
 rand.workspace = true